search

kowith337 / PersonalFilterListCollection

Total resources of documentation, filterlists, hosts file, ruleset that I've created, mostly for private use and/or test.
Other
138 stars 21 forks source link

Fix auto-complete on GelboLube #61

Closed RedSQL closed 4 years ago

RedSQL commented 4 years ago

Fixes auto-complete due to recent change.

This allows for auto-complete script to load, and it appears that previously, auto-complete was used by misc script. I have not touched the misc script loading. If it's not needed anymore - you can remove it at your discretion.

kowith337 commented 4 years ago

Thanks for this update, it's good to be merged, however.

I'm not sure that they intent to put shady script to bait us for bypassing ads and tracking code or not, because the excluded rules contain wildcards between autocomplete. *`**.js, self concern is they may add shady script and name it likeautocomplete.**poop**.js` or any similar of it...

Or let's put the faith that they may just rename legitimate autocomplete script to autocomplete.min.js for easy to understand that it's not a hostile script.

I'm also noticed that they rename its core script from application.js to application3.js, so I'll put this update as well.

RedSQL commented 4 years ago

Thanks!

I put an asterisk there so it loads whatever auto-complete script is named, since the name can change a little bit. I have tried to future-proof it, but I understand why that may be bad...

I'm not sure that they intent to put shady script to bait us for bypassing ads and tracking code or not, because the excluded rules contain wildcards between autocomplete. * .js, self concern is they may add shady script and name it like autocomplete. poop .js or any similar of it...

I have thought so, that owner may try to side-load malicious ad script when it's disguised by something else. If that at any point happens, the script could just be blocked from loading in the future.