search

kowr / compcache

Automatically exported from code.google.com/p/compcache
0 stars 0 forks source link

Build bug -- zcache.o not beign remade after zcache.c change #91

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. build kernel with zcache enabled as built-in (CONFIG_ZCACHE=y) (probably 
would also break for =m)
2. change contents of drivers/staging/zcache/zcache.c
3. run `make'
4. problem: the zcache.o is not being re-built; old version is used

What version of the product are you using? On what operating system?
linux-3.0-rc2

Please provide any additional information below.
This problem is result of zcache.o's dependencies not being listed in 
.zcache.o.cmd aux file. That in turn is caused by the zcache `module' being 
named the same as one partial file -- module is zcache.o, partial file is 
zcache.o as well.

To fix it, re-name zcache.c to anything else (for example, zcache-core.c) and 
update Makefile to make it read something like:
zcache-y := zcache-core.o tmem.o
obj-$(CONFIG_ZCACHE) += zcache.o

Original issue reported on code.google.com by dexen.de...@gmail.com on 8 Jun 2011 at 1:24

GoogleCodeExporter commented 9 years ago 
I had similar change in my local repo where I changed it to zcache_drv (to keep 
naming similar to zram) but never posted it to lkml. Can you please send this 
change to linux-kernel mailing list for mainline inclusion?

Thanks.

Original comment by nitingupta910@gmail.com on 21 Jun 2011 at 2:41

GoogleCodeExporter commented 9 years ago 
dun: http://article.gmane.org/gmane.linux.kernel/1158300

what a silly patch; so many lines, so little changes :p

Original comment by dexen.de...@gmail.com on 22 Jun 2011 at 10:40

GoogleCodeExporter commented 9 years ago 
Thanks dexen!

Original comment by nitingupta910@gmail.com on 22 Jun 2011 at 2:58

GoogleCodeExporter commented 9 years ago 
Fixed by Dexen. Closing the issue.

Original comment by nitingupta910@gmail.com on 29 Jun 2011 at 6:30

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Well the fix is not applied into Linus' tree, unfortunately. Konrad Rzeszutek 
Wilk mail-asked Dan Magenheimer 
(http://thread.gmane.org/gmane.linux.kernel/1158300), and there's no reply on 
LKML yet. Perhaps you can push some action forward...?

Original comment by dexen.de...@gmail.com on 29 Jun 2011 at 6:55