Closed luca-knaack-webcom closed 6 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
main@28be37d
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
While there is still one failing pipeline, this is the godspeed-benchmark, that isn't able to run on any PR's pipeline.
Comparing luca-knaack-webcom:fix/pydantic-1-10-9-with-py-3-12
(611d070) with main
(28be37d)
✅ 29
untouched benchmarks
@koxudaxi, I had to change the codspeed-benchmark
action to always install the dependencies, as the cached virtual environment seems to lack the pytest-xdist
package. Once the cache is refreshed, the commented out line could be reintroduced.
@cclauss Thank you for spending so much time on this difficult issue. I was commenting on the code, but I am concerned about the support for other versions, but I don't think it is a problem now, so I will merge it. Thank you very much.
For performance reasons, you may also want to include a version check on the pydantic side.
There are errors in pipelines that run the testing configuration
python=3.12
andpydantic=1.10.9
. The error is something like:and results in a massive amount of errors like:
To patch the missing
recursive_guard
keyword argument, I created apydantic_patch
file that gets imported early indatamodel_code_generator.__init__.py
and that patches the underlyingevaluate_forwardref
function.This PR is should fix most of the broken tests in the pipelines for pull requests #2013, #2009 and #2008.