koxudaxi / datamodel-code-generator

Pydantic model and dataclasses.dataclass generator for easy conversion of JSON, OpenAPI, JSON Schema, and YAML data sources.
https://koxudaxi.github.io/datamodel-code-generator/
MIT License
2.65k stars 296 forks source link

Fix merging config and args #2015

Closed mahdilamb closed 1 month ago

mahdilamb commented 3 months ago

Currently the config and args don't combine if they are sequences or dictionaries. This serves to fix that

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #2015 will not alter performance

Comparing mahdilamb:fix/merge-config-and-args (3fc6292) with main (e4fa23a)

Summary

✅ 29 untouched benchmarks

koxudaxi commented 3 months ago

@mahdilamb Thank you for creating the PR. The unittest failed. Could you please fix it to keep the current behavior?

mahdilamb commented 3 months ago

Will do in the next few days! A bit busy at the moment, but it's on my radar!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e4fa23a) to head (3fc6292).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2015 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 38 38 Lines 4199 4199 Branches 967 968 +1 ========================================= Hits 4199 4199 ``` | [Flag](https://app.codecov.io/gh/koxudaxi/datamodel-code-generator/pull/2015/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Koudai+Aono) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/koxudaxi/datamodel-code-generator/pull/2015/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Koudai+Aono) | `99.66% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Koudai+Aono#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mahdilamb commented 2 months ago

@koxudaxi that should be everything fixed

koxudaxi commented 1 month ago

@mahdilamb I'm sorry for the late reply. Thank you very much!!