ZacharySpector commented 4 years ago

I'm using pydataapi with boto3 version 1.13.23 and sqlalchemy 1.3.17 without issue. The requirement to use an old version is causing some trouble with continuous integration, though.

This PR loosens the requirements in setup.cfg to allow changes in micro versions within 1.12 and 1.13.

codecov[bot] commented 4 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          593       593           
  Branches        84        84           
=========================================
  Hits           593       593

Flag	Coverage Δ
#unittests	`100.00% <100.00%> (ø)`

Impacted Files	Coverage Δ
pydataapi/dbapi.py	`100.00% <100.00%> (ø)`
pydataapi/dialect/base.py	`100.00% <100.00%> (ø)`
pydataapi/pydataapi.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f00488...e2326cb. Read the comment docs.

koxudaxi commented 4 years ago

@ZacharySpector Thank you for creating this issue. The suggestion looks very good. Btw, Your commit history is broken. I would get only a commit for your changes. Would you please sync upstream and change commit history with git reset --hard? https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

ZacharySpector commented 4 years ago

I think you meant rebase, so I did that

koxudaxi commented 4 years ago

@ZacharySpector

I have released the version as 0.4.18 Thank you very much.

koxudaxi / py-data-api

Be less strict with the boto3 and sqlalchemy version requirements #66

Codecov Report