Files are not formatted on save

koxudaxi / ruff-pycharm-plugin

PyCharm plugin for ruff. This plugin provides reformat code using ruff.

MIT License

196 stars 9 forks source link

Files are not formatted on save #297

Open realsuayip opened 10 months ago

realsuayip commented 10 months ago

Describe the bug

I've enabled Run ruff when the python file saved setting, however it does not format (as in ruff format) the file. It applies quick fixes though.

Conversely, Run ruff when Reformat Code seems to be working fine (applying formatter and quick fixes).

To Reproduce

Have a file ruff format would modify
Save the file with the relevant setting on

Expected behavior Formatter should run on save as well.

Environments (please complete the following information):

IDE: [ PyCharm Professional 2023.2 ]
OS: [ macOS 14 ]
Ruff Version [ 0.1.2 ]
Plugin version [ 0.0.24 ]

koxudaxi commented 10 months ago

Thank you for reporting it. I will check it tonight.

koxudaxi commented 10 months ago

@realsuayip I have released the fixed version as 0.0.25.

Thank you so much.

stv8 commented 4 months ago

I have this same issue currently on PyCharm 2024.1 (Professional Edition)

These are my settings, and when I hit cmd+s it doesn't appear that ruff format runs.

However when I run cmd+opt+l (explicit reformat) it appears to run

creat89 commented 4 months ago

@stv8 I "had" the same issue, but I don't know if the issue was:

Pycharm, which I updated to version 2024.1.1 from 2024.1

An error in my code, such as:

error: Failed to code.py:50:5: Expected an indented block after function definition
code.py:50:5: E999 SyntaxError: Expected an indented block after function definition

This error was blocking the check and the format commands from running.

However, if I used the reformat command, it was running the format command.

koxudaxi commented 4 months ago

@stv8 @creat89 Thank you for reporting the issue. I will fix it.

nathggns commented 3 weeks ago

Also experiencing this