search

koxudaxi / ruff-pycharm-plugin

PyCharm plugin for ruff. This plugin provides reformat code using ruff.
MIT License
222 stars 10 forks source link

LSP4IJ should be optional #494

Closed koxudaxi closed 2 months ago

koxudaxi commented 2 months ago

Fixes: https://github.com/koxudaxi/ruff-pycharm-plugin/issues/490

github-actions[bot] commented 2 months ago

Qodana Community for JVM

23 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 3
Unused import directive 🔶 Warning 5
Unused symbol 🔶 Warning 5
Incorrect string capitalization 🔶 Warning 1
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Unstable API Usage 🔶 Warning 1
Package name does not match containing directory ◽️ Notice 2
Array property in data class ◽️ Notice 1
Const property naming convention ◽️ Notice 1
Class member can have 'private' visibility ◽️ Notice 1
Lambda argument inside parentheses ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report To be able to view the detailed Qodana report, you can either: - Register at [Qodana Cloud](https://qodana.cloud/) and [configure the action](https://github.com/jetbrains/qodana-action#qodana-cloud) - Use [GitHub Code Scanning with Qodana](https://github.com/jetbrains/qodana-action#github-code-scanning) - Host [Qodana report at GitHub Pages](https://github.com/JetBrains/qodana-action/blob/3a8e25f5caad8d8b01c1435f1ef7b19fe8b039a0/README.md#github-pages) - Inspect and use `qodana.sarif.json` (see [the Qodana SARIF format](https://www.jetbrains.com/help/qodana/qodana-sarif-output.html#Report+structure) for details) To get `*.log` files or any other Qodana artifacts, run the action with `upload-result` option set to `true`, so that the action will upload the files as the job artifacts: ```yaml - name: 'Qodana Scan' uses: JetBrains/qodana-action@v2024.1.2 with: upload-result: true ```
Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions
angelozerr commented 2 months ago

Thanks for the fix.

I'm annoyed that you have some trouble with LSP4IJ.

But as it is optonnal now, user can skip it if needed. Could you please create a PR to add your plugin at https://github.com/redhat-developer/lsp4ij?tab=readme-ov-file#who-is-using-lsp4ij