search

koyeongmin / PINet

MIT License
207 stars 56 forks source link

code logic error #25

Open gneworld opened 4 years ago

gneworld commented 4 years ago

hi, I found an error in generate_result function in test.py file, that is " if (np.sum(feature[i]**2))>=0:", this condition will always be true. so it is redundant conditional statement?

lane_feature = [] x = [] y = [] for i in range(len(grid)): if (np.sum(feature[i]*2))>=0: point_x = int((offset[i][0]+grid[i][0])p.resize_ratio) point_y = int((offset[i][1]+grid[i][1])*p.resize_ratio) .............

gneworld commented 4 years ago

@koyeongmin hello, could you give an explanation about this? thanks

koyeongmin commented 4 years ago

Oh! It looks unnecessary condition. I think I forgot to delete the condition while experimenting with various conditions.

gneworld commented 4 years ago

@koyeongmin thanks much