koying / SPMC

fork of xbmc/kodi
Other
633 stars 257 forks source link

Menu to add to Faviourites not working again. #727

Open slayerkodi opened 7 years ago

slayerkodi commented 7 years ago

I actually reported this problem a while ago and you fixed it koying but it seems to be broken again. Going to android programs and pressing x on shield TV controller to bring menu to add to favourites is disabled. Also I've noticed a few android apps open differently inside spmc as if they think its being opened from phone, where as leanback launcher they launch normally. E.g Vevo music app.

slayerkodi commented 7 years ago

Also forgot to add this, if a video is playing and you use voice search in spmc, spmc will crash every time without fail. Since updating my shield to latest firmware I used the live channels app with picture in picture and did a search and it muted the video audio and let you search while the video was still playing and then reverted after your search was complete. Is there a way to implement this. I forget this happens all the time and have to force close

koying commented 7 years ago

State the version, please

slayerkodi commented 7 years ago

16.5-5 Got:2016-12-29-972797-dirty

koying commented 7 years ago

I tested both on 16.6 and it seems to work

1) Only rings a distant bell. Do you still have the references somewhere 2) Is definitely something 16.6 is meant to fix

slayerkodi commented 7 years ago

Sorry I dont have references, but just thought to myself I am using g a custom keypad layout for spmc, I only changed the b button to back instead if stop though so not sure why that would affect the x button. And yeah ill test on 16.6 for the second problem now

slayerkodi commented 7 years ago

OK so I tested with the 16.6 beta 2 apk and can confirm the add to favourites works so must be my kepad layout, but the opening as phone app still happens. Use vevo from google play store and open from launcher then spmc to see the difference.

koying commented 7 years ago

opening as phone app

Nothing I can do, at first sight. I assume those detect if they're lauched from leanback and change UI accordingly.

slayerkodi commented 7 years ago

Is there anyway we can map the triggers to rewind and fast forward like the YouTube app let's you on shield?? And how is the pip support going??