search

koying / SPMC

fork of xbmc/kodi
Other
632 stars 257 forks source link

[REQUEST] A new AudioEngine sink for AAudio API for Pro Audio #901

Closed Hedda closed 7 years ago

Hedda commented 7 years ago

AAudio is a new Android C API introduced in the Android 8.0 (Oreo) preview release. It is designed for high-performance audio applications that require low latency. Apps communicate with AAudio by reading and writing data to streams.

https://developer.android.com/ndk/guides/audio/aaudio/aaudio.html

Assume that SPMC / Kodi needs a new AudioEngine sink to utilize this on Android "O"?

https://developer.android.com/preview/index.html

This new API can improve the stereo/surround audio upmixing and downmixing functionality of Kodi.

LukeM-Github commented 7 years ago

What would be the benefit?

Hedda commented 7 years ago

Example get high fidelity audio output when not bitstreaming, like when using Audio DSP addons

Read http://forum.kodi.tv/showthread.php?tid=252871

As well as http://kodi.wiki/view/Audio_DSP

And all other threads in the Audio DSP forum http://forum.kodi.tv/forumdisplay.php?fid=235

AchimTuran vision is for Kodi to get native high fidelity audio output without bitstreaming.

LukeM-Github commented 7 years ago

I still don't get it. What does high fidelity or DSP have to do with low latency?

Hedda commented 7 years ago

DSP adds latency. Using a low-latency API could compensate for that.

LukeM-Github commented 7 years ago

For playback, all you care about is keeping video and audio in sync. Latency only matters for interactive stuff.

koying commented 7 years ago

Won't happen by me. DSP is overkill, IMO, with all due respect to the DSP addons, this is just a media player, after all.

AchimTuran commented 7 years ago

DSP is overkill, IMO, with all due respect to the DSP addons, this is just a media player, after all.

No, it e.g. improves the stereo upmixing functionality, which is currently very ugly. It might still be a player but with more configurations and setup possibilities after AudioDSP V2 went in.

koying commented 7 years ago

With still all due respect, upmixing is pretty much an AVR basic functionality ;)

AchimTuran commented 7 years ago

Sure, but wait until you hear freesurround. It is much better for movies with a better understandable center speaker for voices.

Hedda commented 6 years ago

@koying FYI; AchimTuran is the Team Kodi developer behind Kodi's new Audio DSP funtions:

http://kodi.wiki/view/Audio_DSP

It even has its own subforum in the kodi.tv forum:

https://forum.kodi.tv/forumdisplay.php?fid=235

So with all due respect, no, DSP is not overkill on Android ;)

AchimTuran commented 6 years ago

I guess that @koying is aware of what AudioDSP will do and should know the subforum. I met him many times during Kodi DevCons. ;) Another reason is that we are both team members.