Fix Pylint problems - Githubissues

kozaka-tv / Rocksmith-Servant

MIT License

6 stars 5 forks source link

Fix Pylint problems #258

Closed kozaka-tv closed 4 months ago

kozaka-tv commented 4 months ago

Pylint Github action reports a lot of problems/warnings, let's fix them and have a green build!

ZsannaK commented 4 months ago

I made all the changes I could without bigger refactoring or change. Please review!

kozaka-tv commented 4 months ago

All good! I think what left could be solved later in some separate refactoring issues.

I set the fail-under=9.5 to have some space and time to fix things without breaking the build However, I set also the fail-on=import-error to still it should fail on import problems.

Can you maybe fix the import problems?

Interesting thing is, that locally, for me it is working, and no import problem is reported by Pylint or by the IDE.

kozaka-tv commented 4 months ago

I fixed the import problem, now it looks fine. Can you please make the PR ready?