Open LinuxJoeUser opened 6 years ago
Problem with this is that it will interfere with workflow that goes other way around - I have everything set up and need to change from Menu A to Menu B. Doing so should not change control options.
In reviewing this issue I realized that menu Type also needs to be saved as a part of a menu. (eek). Also, think of this issue in combination with #417
I suppose an alternative to saving a Menu's Type, Controls, and Position (TCP) automatically is to offer each as an option with a checkbox:
Think of it like this: The Type, Control, and Postition of a Menu (that is its TCP) is integral to what makes a menu different from just a list. As it is now it's basically just a list that we turn into a menu by adding presentation (type), interaction (controls), and location (position).
I'm suggesting that saving the menu as a whole---tweaking it as necessary---is better than what we have now, which is saving a list and having to reapply the TCP each and every time we use it in order for it to be the menu we want.
Problem with this is that it will interfere with workflow that goes other way around ...
In your example, someone is swapping Menu A for Menu B and wants to keep type, control, and position and the same for A as it was for B. Ok, yes, in this example the TCP would need to be edited in Menu B ---maybe even requiring copying Menu B in ~/.config/SCC/menus and creating a Menu C--- but this is a very specific case, and seems much more the exception than the rule.
Personally, I've never encountered this situation creating profiles (50 currently active). Yes they would have to do a bit more work, but this is going to happen a lot less than wanting to keep things the same for a menu. I always want my hotkeys1-0
to be horizontal, LPAD, A, B, bottom centered. I always want my weapon selection wheel to be radial, LPAD, LPAD press, cancel on release, and in the bottom left corner of the screen.
Ok, I think I'm moved by your arguments. Making those settings part of menu and menu editor solves more than it breaks. I can even leave current options as override, accessible using custom action.
I just have to think about how to convert already existing setups so behavior doesn't change between updates.
Hi Kozec! Hope you're doing well. Any chance this particular enhancement will ever be implemented? :)
By default, when a Menu is saved after creation or editing, the Menu Type, Control, and Position settings should be saved as part of that particular menu. Especially Type.
For example, I create a menu called
Hotkey1-6 (global)
to be controled with LPAD, selected with [A] button, and escaped with [B] button; located in the bottom right corner at at such and such a size. When I save it then later use it in another profile, the Control and Position settings would be controlled with LPAD, selected with [A] button, and escaped with [B] button etc..Currently these require resetting each time a menu is created or edited.