search

kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.3k stars 138 forks source link

Use fsWatcherEnabled #430

Closed jtojnar closed 6 years ago

jtojnar commented 6 years ago

Since syncthing 0.14.40, there is apparently built-in filesystem monitoring, which replaced syncthing-inotify. Could it be used instead of pyinotify?

Pyinotify is not available on Nix on MacOS, so we cannot offer syncthing-gtk there.

kozec commented 6 years ago

Interesting, I was not aware that's already done. I have branch that remove filesystem watching, I'll try to merge it and see what it does.

Byt ST-GTK is really not supported on MacOS, I have no machine to test it with it.

kozec commented 6 years ago

@calmh sorry to bother you, but release notes for 0.14.40 sounds like fsWatcherEnabled is there just for testing. Is it good idea to remove watching from ST-GTK and rely on it now, or would it be better to wait?

calmh commented 6 years ago

I’d suggest waiting as there is no UI to control it properly from Syncthing yet. I’ll be there in a release or two.

kozec commented 6 years ago

Ok, thanks. @jtojnar, I made sure that pyinotify is optional dependency, so until that's ready, ST-GTK can be used as it is, but inotify option will be disabled.

hackel commented 6 years ago

What is the current status of this issue? Syncthing 0.14.47 is out, and I just got a message about enabling "Watching for changes" in the web interface, along with the Warning: "If you are using an external watcher like syncthing-inotify, you should make sure it is deactivated." I certainly don't want two have two watchers running. Is it enough to just uninstall python-pyinotify?

kozec commented 6 years ago

I certainly don't want two have two watchers running. Is it enough to just uninstall python-pyinotify?

Yes, but you may need it for other things as well :D I'm currently little busy, but I'll try to get support for soon.