kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.29k stars 140 forks source link

Some icons don't match the overall L&F #459

Closed memeplex closed 5 years ago

memeplex commented 6 years ago

The menu has some coloured icons (settings, shutdown, show id) that don't play well with the rest of the icons and also modern gnome/gtk design. There is a lot of high quality svg icons in https://github.com/PapirusDevelopmentTeam/papirus-icon-theme to pick from.

memeplex commented 6 years ago

Also "Edit ignore patterns".

memeplex commented 6 years ago

Some suggestions:

The last one is not an eye but a crossed eye, which I think is more meaningful because these are patterns to ignore (not look at).

kozec commented 6 years ago

Both settings and shutdown are taken from theme, but "edit ignore patterns" isn't. I'll have to check if GPL3 icon can be used with GPL2 program.

memeplex commented 6 years ago

What are the names of settings and shutdown icons? They really don't look like most icons in my theme, by all means not like menu/toolbar icons.

On Wed, Jun 13, 2018, 5:01 PM kozec notifications@github.com wrote:

Both settings and shutdown are taken from theme, but "edit ignore patterns" isn't. I'll have to check if GPL3 icon can be used with GPL2 program.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/syncthing/syncthing-gtk/issues/459#issuecomment-397066889, or mute the thread https://github.com/notifications/unsubscribe-auth/ACtq-YKBjiAS2JSQIJspj00hGHMPPXKWks5t8W-xgaJpZM4UmgAQ .

kozec commented 6 years ago

preferences-system and system-shutdown. Maybe your theme doesn't include them and so fallbacks from Adwaita are used?

kozec commented 5 years ago

Sorry, but I found this to be surprisingly hard change and potential licence mess, so I decided that current icons are fine :)