kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.29k stars 140 forks source link

Fix spelling mistakes, remove unnecessary whitespace characters #471

Closed dralley closed 6 years ago

dralley commented 6 years ago

Probably better to look at individual commits, because there's just so much noise from the "remove unnecessary tab/whitespace characters" commit.

My editor does that automatically, and since I've been making / maybe going to make several PRs, it's better to just it out of the way now so it doesn't get in the way and/or make the other PRs harder to read.

kozec commented 6 years ago

from the "remove unnecessary tab/whitespace characters" commit.

Please, don't :D

All this going to do is to cause me and my editor to re-add that withespace back in every file I touch in following commits, causing even more white noise. I can deal with it here-and-there, but not when changed in every file in repository...

dralley commented 6 years ago

Would it really add them back? I would think it's just where the editor adds indentation when you hit "enter" to keep the cursor in the same spot, but doesn't remove it if you do another "enter" to go the line down. Which means they kind of just get "left behind" but not added on save or anything.

Anyway I can just drop the commit if you want. Nbd.

dralley commented 6 years ago

Rebased to resolve merge conflicts.

Would you still prefer the whitespace commit dropped?

kozec commented 6 years ago

Would you still prefer the whitespace commit dropped?

Yes, definitely.

dralley commented 6 years ago

@kozec commit dropped

kozec commented 6 years ago

Ok, merged. Thanks :)