kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.29k stars 140 forks source link

Use print_function from future #473

Closed dralley closed 6 years ago

dralley commented 6 years ago

In Python 3, 'print' was changed from a keyword into a builtin function. We can use this function from Python 2 if we import it from __future__.

kozec commented 6 years ago

This shouldn't really be needed, all those prints are meaningless and I can just remove them. Any normal output should go through logger.

dralley commented 6 years ago

Removed entirely or replaced with logging statements?

dralley commented 6 years ago

I can just update my PR to do this. Some of them it might make sense to log at the info/debug level?

kozec commented 6 years ago

Just as side note, those .exe and _windows things are used only to build Windows release, so there's probably not much sense in changing them.