search

kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.29k stars 140 forks source link

Unparsed HTML in notification popup on Gnome #478

Closed benruijl closed 6 years ago

benruijl commented 6 years ago

When a file is synchronized, the gnome notification popup contains an unparsed html link, as shown in the image below:

popupbug

Version Information

Syncthing Version: v0.14.48 OS Version: Arch Linux Gnome version: 3.26

benruijl commented 6 years ago

This issue appears to be a problem in libnotify. I have filed a bug report here: https://gitlab.gnome.org/GNOME/libnotify/issues/2

benruijl commented 6 years ago

This is the answer from the Gnome Shell development team: https://gitlab.gnome.org/GNOME/gnome-shell/issues/549#note_311728. So syncthing-gtk should check if the body-hyperlinks is set. If not, the HTML link should not be stripped.

edit: I see there already is code in place for the check (https://github.com/syncthing/syncthing-gtk/blame/master/syncthing_gtk/notifications.py#L217). I'll see what's going on.

benruijl commented 6 years ago

I understand now: the current release is quite old, and this bug has been fixed since https://github.com/syncthing/syncthing-gtk/commit/d352ce18bc81c7cda24153b55b210d94a0424f14.

kozec commented 6 years ago

Sounds like it's time to make another.