i3 not being detected properly

kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing

GNU General Public License v2.0

1.29k stars 140 forks source link

i3 not being detected properly #494

Closed laelath closed 5 years ago

laelath commented 5 years ago

I am encountering the same issue as #188, but this is fixed by calling XDG_CURRENT_DESKTOP=i3 syncthing-gtk -m which leads me to believe that the method previously used to detect an i3 desktop is no longer working.

kozec commented 5 years ago

Then i3 desktop is broken :)

What gives echo $XDG_CURRENT_DESKTOP to you in freshly spawned terminal?

laelath commented 5 years ago

Ahh, looks like that environment variable is no longer getting set. I'll submit the issue with i3.

laelath commented 5 years ago

Apparently i3 has never set that variable, now I'm not sure why starting minimized ever worked, weird. Guess i3 users just have to set it before launching

kozec commented 5 years ago

Well, considering that i3 is "just" a WM, it makes some sense. If there is any sure way to detect it, I can change code handling detection, otherwise just set XDG_CURRENT_DESKTOP in .xinitrc or .profile.

laelath commented 5 years ago

Looking at the output of env, the only one I see that mentions i3 is DESKTOP_STARTUP_ID which begins with i3/, not sure how standard this variable is though.