search

kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.29k stars 140 forks source link

Correct language code for Simplified Chinese #511

Closed yan12125 closed 5 years ago

yan12125 commented 5 years ago

zh means Chinese, zh_CN means "Chinese used in China", namely Simplified Chinese, which is quite different from other Chinese variants like zh_TW "Chinese used in Taiwan", namely Traditional Chinese.

Before this change, zh_TW users will see Syncthing-GTK in Simplified Chinese. This is not expected.

(Well, I'm not sure if my explanation around different Chinese variants is clear or not. Feel free to ask me :)

This change also matches the following line in locale/zh_CN/LC_MESSAGES/syncthing-gtk.po:

"Language: zh_CN\n"
st-review commented 5 years ago

:robot: beep boop

I'm going to close this pull request as it has been idle for more than 90 days.

This is not a rejection, merely a removal from the list of active pull requests that is periodically reviewed by humans. The pull request can be reopened when there is new activity, and merged once any remaining issues are resolved.

yan12125 commented 5 years ago

I consider this pull request ready for review. Can anyone reopen it?

yan12125 commented 5 years ago

Alright, after finding a similar case https://github.com/syncthing/syncthing-gtk/pull/497, I consider the culture here is less than ideal for some contributors. I will switch to qsyncthingtray.