search

kozec / syncthing-gtk

GTK3 & python based GUI for Syncthing
GNU General Public License v2.0
1.3k stars 138 forks source link

Flatpak: Icons missing #566

Open plafue opened 4 years ago

plafue commented 4 years ago

I'm using Pop_OS, which per default installs syncthing-gtk from flathub.

The icon in the notification area looks like this:

image

And the icon in the title bar looks like this: image

Starting the application from the command line with the --debug flag displays the following output:

≻  /usr/bin/flatpak run --branch=stable --arch=x86_64 --command=syncthing-gtk me.kozec.syncthingtk --debug
Gtk-Message: 09:26:53.296: Failed to load module "appmenu-gtk-module"
D UIBuilder     Enabled: header_bar
D UIBuilder     Enabled: is_gnome
D UIBuilder     Enabled: icons_in_menu
D UIBuilder     Loading glade file /app/bin/../share/syncthing-gtk/app.glade
D UIBuilder     Enabled conditions: set([u'icons_in_menu', u'is_gnome', u'header_bar'])
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Removed node !is_gnome | old_gtk
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'property' by attribute: old_gtk
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'child' by attribute: traditional_header
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Removed node traditional_header
D UIBuilder     Allowed node traditional_header | icons_in_menu
I StatusIcon    Using backend StatusIconGTK3 (primary)
D Daemon        Reading syncthing config /home/plafue/.var/app/me.kozec.syncthingtk/config/syncthing/config.xml
V Notifications Error notifications enabled
V Notifications File update notifications enabled
I App
I App           Syncthing-GTK started and running in notification area
V Daemon        Set refresh interval to 5
W StatusIcon    StatusIcon: Using backend StatusIconAppIndicator (fallback)
E Daemon        g-io-error-quark: Could not connect to 127.0.0.1: Connection refused (39)
Traceback (most recent call last):
  File "/app/lib/python2.7/site-packages/syncthing_gtk/daemon.py", line 1057, in _connected
    self._connection = self.connect_to_service_finish(results)
Error: g-io-error-quark: Could not connect to 127.0.0.1: Connection refused (39)
D App           Creating connect_dialog
[...]
plafue commented 4 years ago

Related issue: https://github.com/flathub/me.kozec.syncthingtk/issues/13

kozec commented 4 years ago

Sorry but I'm not managing nor supporting flatpack repository.

plafue commented 4 years ago

No problem. Feel free to close the ticket. Thanks for commenting!

On October 20, 2020 1:20:38 PM UTC, kozec notifications@github.com wrote:

Sorry but I'm not managing nor supporting flatpack repository.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/kozec/syncthing-gtk/issues/566#issuecomment-712844460 -- Sent from my mobile device. Please excuse my brevity.

brettwilcox commented 2 years ago

Sorry but I'm not managing nor supporting flatpack repository.

@kozec Hi! I came across this issue when I installed Syncthing on my new Steam Deck (running Arch Linux). I'm having an issue getting the status icons to work.

https://github.com/flathub/me.kozec.syncthingtk/issues/13

As the Valve Steam Deck hit's the market, there will be an influx of new users trying out Linux and Arch for the first time. To improve the experience, the icons should be addressed. It can be driven downstream in a patch, but we wanted to see if you would be willing to take another look at this here.

@TingPing proposed this as a fix:

They just need to have the prefix me.kozec.syncthingtk, so me.kozec.syncthingtk.black-0.png would work for example.

I see the following files referencing the icons. Without starting a deep dive into code I don't understand, are these the main file that would need to be touched?

Would you be willing to support a pull request here with a patch?

Thanks!! :)

Sanfe commented 1 year ago

As [brettwilcox] mentioned, there will be a huge volume of new users to the app that could found the missing icon a bit weird, when this app is great and very professional.

0verEngineer commented 1 year ago

@kozec Hey, i find it very sad that you will not support flatpak, many distros use it as default and it is a great way for app distribution. However i respect your decision about that but can you please answer the Questions brettwilcox asked above?

That would help a lot so someone can step up and fix this stuff.