Building master fails

[rex4539]

After the commits made in zcash master in the last couple of days, build fails.

Making all in src
rm -f libbitcoin_server.a
/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -mmacosx-version-min=10.8 -stdlib=libc++ -std=c++11 -DHAVE_CONFIG_H -I. -I../src/config  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -I. -I./obj -pthread -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include -I./leveldb/include -I./leveldb/helpers/memenv -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I./secp256k1/include -I./snark -I./snark/libsnark -I./univalue/include  -Qunused-arguments -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DMAC_OSX  -Wformat -Wformat-security -Wstack-protector -fstack-protector-all -Werror -fPIE -pipe -O2 -g -fwrapv -fno-strict-aliasing -Wno-undefined-var-template -MT consensus/libbitcoin_common_a-upgrades.o -MD -MP -MF consensus/.deps/libbitcoin_common_a-upgrades.Tpo -c -o consensus/libbitcoin_common_a-upgrades.o `test -f 'consensus/upgrades.cpp' || echo './'`consensus/upgrades.cpp
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar cr libbitcoin_server.a libbitcoin_server_a-sendalert.o libbitcoin_server_a-addrman.o libbitcoin_server_a-alert.o libbitcoin_server_a-asyncrpcoperation.o libbitcoin_server_a-asyncrpcqueue.o libbitcoin_server_a-bloom.o libbitcoin_server_a-chain.o libbitcoin_server_a-checkpoints.o libbitcoin_server_a-deprecation.o libbitcoin_server_a-httprpc.o libbitcoin_server_a-httpserver.o libbitcoin_server_a-init.o libbitcoin_server_a-leveldbwrapper.o libbitcoin_server_a-main.o libbitcoin_server_a-merkleblock.o libbitcoin_server_a-metrics.o libbitcoin_server_a-miner.o libbitcoin_server_a-net.o libbitcoin_server_a-noui.o libbitcoin_server_a-paymentdisclosure.o libbitcoin_server_a-paymentdisclosuredb.o policy/libbitcoin_server_a-fees.o libbitcoin_server_a-pow.o libbitcoin_server_a-rest.o libbitcoin_server_a-rpcblockchain.o libbitcoin_server_a-rpcmining.o libbitcoin_server_a-rpcmisc.o libbitcoin_server_a-rpcnet.o libbitcoin_server_a-rpcrawtransaction.o libbitcoin_server_a-rpcserver.o script/libbitcoin_server_a-sigcache.o libbitcoin_server_a-timedata.o libbitcoin_server_a-torcontrol.o libbitcoin_server_a-txdb.o libbitcoin_server_a-txmempool.o libbitcoin_server_a-validationinterface.o   
/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -mmacosx-version-min=10.8 -stdlib=libc++ -std=c++11 -DHAVE_CONFIG_H -I. -I../src/config  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -I. -I./obj -pthread -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include -I./leveldb/include -I./leveldb/helpers/memenv -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I./secp256k1/include -I./snark -I./snark/libsnark -I./univalue/include  -Qunused-arguments -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DMAC_OSX  -Wformat -Wformat-security -Wstack-protector -fstack-protector-all -Werror -fPIE -pipe -O2 -g -fwrapv -fno-strict-aliasing -Wno-undefined-var-template -MT primitives/libbitcoin_common_a-block.o -MD -MP -MF primitives/.deps/libbitcoin_common_a-block.Tpo -c -o primitives/libbitcoin_common_a-block.o `test -f 'primitives/block.cpp' || echo './'`primitives/block.cpp
/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -mmacosx-version-min=10.8 -stdlib=libc++ -std=c++11 -DHAVE_CONFIG_H -I. -I../src/config  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -I. -I./obj -pthread -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include -I./leveldb/include -I./leveldb/helpers/memenv -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I./secp256k1/include -I./snark -I./snark/libsnark -I./univalue/include  -Qunused-arguments -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DMAC_OSX  -Wformat -Wformat-security -Wstack-protector -fstack-protector-all -Werror -fPIE -pipe -O2 -g -fwrapv -fno-strict-aliasing -Wno-undefined-var-template -MT primitives/libbitcoin_common_a-transaction.o -MD -MP -MF primitives/.deps/libbitcoin_common_a-transaction.Tpo -c -o primitives/libbitcoin_common_a-transaction.o `test -f 'primitives/transaction.cpp' || echo './'`primitives/transaction.cpp
consensus/upgrades.cpp:70:1: error: control may reach end of non-void function [-Werror,-Wreturn-type]
}
^
1 error generated.
make[5]: *** [consensus/libbitcoin_common_a-upgrades.o] Error 1
make[5]: *** Waiting for unfinished jobs....
mv -f primitives/.deps/libbitcoin_common_a-block.Tpo primitives/.deps/libbitcoin_common_a-block.Po
mv -f primitives/.deps/libbitcoin_common_a-transaction.Tpo primitives/.deps/libbitcoin_common_a-transaction.Po
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib libbitcoin_server.a
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [zcash_build] Error 2
make[1]: *** [build] Error 1
make: *** [zcash_all] Error 2

[kozyilmaz]

@rex4539 most probably, makefile couldn't apply this patch due to changed codebase. Can you try applying it manually? https://github.com/kozyilmaz/zcash-apple/blob/master/zcash/patches/017-zcash-macos-no-werror.patch

[rex4539]

Now fails with

/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -mmacosx-version-min=10.8 -stdlib=libc++ -std=c++11 -DHAVE_CONFIG_H -I. -I../src/config  -DMULTICORE -fopenmp -fPIC -DBINARY_OUTPUT -DCURVE_ALT_BN128 -DBOOST_SPIRIT_THREADSAFE -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wstack-protector -fstack-protector-all -pie -pipe  -O1 -g -Wstack-protector  -fstack-protector-all -fPIE -fvisibility=hidden -DSTATIC -I. -I./obj -pthread -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include -I./leveldb/include -I./leveldb/helpers/memenv -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/include -I./secp256k1/include -I./snark -I./snark/libsnark -I./univalue/include  -DMONTGOMERY_OUTPUT -Qunused-arguments -I/Users/rex/zcash-apple/zcash/zcash_master/depends/x86_64-apple-darwin17.5.0/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DMAC_OSX  -Wformat -Wformat-security -Wstack-protector -fstack-protector-all -fwrapv -fno-strict-aliasing -pipe -O2 -g -fwrapv -fno-strict-aliasing -Wno-undefined-var-template -MT zcash/libzcash_a-NoteEncryption.o -MD -MP -MF zcash/.deps/libzcash_a-NoteEncryption.Tpo -c -o zcash/libzcash_a-NoteEncryption.o `test -f 'zcash/NoteEncryption.cpp' || echo './'`zcash/NoteEncryption.cpp
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib libbitcoin_common.a
clang: error: unsupported option '-fopenmp'
clang: error: unsupported option '-fopenmp'
make[5]: *** [zcash/libzcash_a-NoteEncryption.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: *** [zcash/libzcash_a-IncrementalMerkleTree.o] Error 1
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib libbitcoin_server.a
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [zcash_build] Error 2
make[1]: *** [build] Error 1
make: *** [zcash_all] Error 2

[kozyilmaz]

@rex4539 these are the issues that are already addressed with my patchsets, probably new changes create conflicts so they are not applied properly. Let me look into it and update them.

[kozyilmaz]

Hey @rex4539 I created a special branch for you :) It points to master and patches are updated https://github.com/kozyilmaz/zcash-apple/tree/rex4539

[rex4539]

Compiled, thanks!