search

kpalang / mirth-plugin-guide

A plugin guide for NextGen Connect
35 stars 11 forks source link

Improve MacOs self signed certificate instructions #8

Open heneryville opened 8 months ago

heneryville commented 8 months ago

The mac instructions provided are missing a ton of flags required for support of various versions of java and library imports. Just adding the command line argument to the launcher is much simpler.

heneryville commented 8 months ago

I wasn't able to get the command line alone working, including using the existing instructions in the README. This is the only way that I've found so far to get the launcher to run with the -k mode. There certainly is another way, but it likely includes about 10-30 command line switches which changed depending on the Java version.

I'm no MacOS expert. There may be a way to make a separate application that does this. But at the very least these method works were the existing one in the README does not.

jonbartels commented 8 months ago

I think the best choice would be to update your PR to include both options. Label one as "One Time Override" and the other as "Permanent Override" or something similar.

The current java -jar option has worked consistently for me for several years of plugin development.

The option you propose is actually really handy if the user has a need to make -k permanent. A developer working in a way where -k can be tolerated for ALL uses of MC benefits from just changing the plist so it is always set.

kpalang commented 8 months ago

I have to agree with Jon here. While for someone who knows what they're doing, your suggestion is absolutely useful. I too have a separate shortcut that disables a bunch of security stuff, but I think disabling shouldn't be the default/recommended behavior.

tonygermano commented 8 months ago

I also disagree with the change in this PR. Many people use the same machine for accessing production/remote instances that they also use for testing while developing plugins. This change intentionally removes necessary security safeguards.

I don't know why the java version would have any impact on setting the flag. The flag is a parameter passed through to MCAL. It is not used by the java command itself.

jonbartels commented 8 months ago

I am going to retract my objection to this PR. I was looking at the README for Windows.

Changing the windows shortcut makes a similar change as the MacOS PLIST file. If its OK for Windows then its OK for Mac.

@kpalang I think listing both permanent and not-permanent flag options is best. WDYT?