kpamela / SOEN343

https://tecmarket.herokuapp.com/
2 stars 0 forks source link

Implement new Requirements #131

Closed CharlesPhilippeLabbe closed 6 years ago

CharlesPhilippeLabbe commented 6 years ago
FrankSauve commented 6 years ago

Task 3 is already complete, but needs to be fixed. Related to issue #128

CharlesPhilippeLabbe commented 6 years ago

When we delete a user, do we delete its purchase history?

FrankSauve commented 6 years ago

I think its better to delete the purchase history because if someone else creates an account with the same username then he will see the old user's purchase history.

Lordofsnails commented 6 years ago

What if i want to restore my account tho ?

FrankSauve commented 6 years ago

I mean if you delete your facebook account for example, you want everything to be deleted no?

FrankSauve commented 6 years ago

Once you delete you can't restore

CharlesPhilippeLabbe commented 6 years ago

I doubt that facebook delete completely ... I agree that we should not be able to restore accounts

LeCleric commented 6 years ago

I'd say deleting everything would be the right call. Seems simpler. Facebook's policies on account termination and our own don't have to match. No reason to make our lives harder than they have to be. If the user wants to keep their purchasing history they shouldn't have voided their registration. They can always use a third party service like eBay or Craiglist or something to get rid of their products. Our fictional responsibility towards providing this service is finished as soon as they cease being our client.

Lordofsnails commented 6 years ago

alright, let's put a lot of alert(" WARNING, DELETED ACCOUNT CANNOT BE RESTORED!!! do you still wish to proceed? Y/N")

LeCleric commented 6 years ago

Yeah that sounds like the right call. Normally we'd just put this information in the terms of service that no one ever reads.

CharlesPhilippeLabbe commented 6 years ago

So, apparently the teacher doesn't want us to delete users fully

CharlesPhilippeLabbe commented 6 years ago

should we remove Admins from RegisteredUsers list?