kpanchen / org.openhab.binding.icomforts30

Lennox iComfort S30 binding for OpenHAB 3
Eclipse Public License 2.0
3 stars 0 forks source link

3.4.3 Feedback #7

Open bspiegel33 opened 1 year ago

bspiegel33 commented 1 year ago

Thank you so much for all your work on this. I really appreciate the progress and effort you have put into this.

Here's my experience with this so far: I uninstalled the previous version, installed 3.4.3 in the addon directory, restarted openhab, and checked habopen to ensure all is ok.
Habopen

All seems to be working.

I looked at the channel list but did not see the new channels (Humidity mode, Humidity Status, Outside temperature). Upstairs channels Downstairs channels System channels

I will test connectivity and responsiveness and report finding.

kpanchen commented 1 year ago

Try to remove thing and add it back again, if you have it configured through file just remove .thing file, wait 5 sec and put it back. Also you can try to clear cache but I never needed to do that.

sudo systemctl stop openhab.service sudo openhab-cli clean-cache sudo systemctl start openhab.service

For responsiveness change message pump interval manually, now I allow it to be as small as 1 sec but I kept default at 5 sec at least for now.

K.

bspiegel33 commented 1 year ago

I tried both techniques. No additional channels appeared. The binding seems stable and stays connected. The minimum pump interval seems to be 2, not 1, which is fine.

Observations:

Changes to setpoint often get reversed. I suspect the binding sends the old HVAC setpoint while the new setpoint has not been acted upon yet. I can use rule code to handle this, but it would be nice if the binding prevented the reversing.

Changes to setpoint start an HVAC "hold" until the next schedule change. It would be helpful to report a hold exists and be able to cancel the hold, which causes the HVAC to revert to the scheduled setpoint.

The HVAC fan runs beyond the System Status change to "Idle" and it runs alone when in circulating mode. It would be helpful to have a channel for zone fan status, even if it just reports the fan is on/off.

I noticed the HVAC sometimes reports heating status but is not acting on it yet. OH and the thermostat mobile app report the same status, so it's an HVAC quirk. Eventually, the HVAC acts on it. I want to run a ceiling fan to mix the air coming from the HVAC. My solution would be SystemStatus=Heating and ZoneFanStatus=ON then run the ceiling fan. I think this would be more reliable than the system status alone. It would also be more reliable for turning off the ceiling fan.

Many thanks for all your work on this. I hope others will use this as well.

kpanchen commented 1 year ago

Not sure why you don't have additional channels, this kind of bugging me, let's try to troubleshoot this. For me all of them appear as soon as JAR file is updated.*High priority

  1. I know about this behaviour and think this is HVAC issue, need to do some testing and capturing here (debug log please).*Priority
  2. Yes, this is a functionality of the binding replicating app behaviour, I'll check if it is possible to add something like cancel channel*Not a priority now
  3. Added, please test.
  4. Same as 3.

Please have a look, let me know! Debug log would be great.

bspiegel33 commented 1 year ago

Will do. Thanks for the update!

bspiegel33 commented 1 year ago

I installed the update. With this new version, making item changes happen more quickly and reliably. I still see no new channels. I did some openhab searching and saw this was a problem for other developers too. I may try deleting the Thing and re-entering, when I have the time. I have "debug" running and will post the logs after accumulating a bigger sample.

bspiegel33 commented 1 year ago

Here's a debug log file. oh.zip

kpanchen commented 1 year ago

I still see no new channels.

On both of my systems prod and lab channels appear right away when I update Jar. Are you using text config or gui?

bspiegel33 commented 1 year ago

My first install was thru the ssh login. I then removed that via ssh login and started using the addon directory for the next 2 version installs. I will try decoupling my items from the channels and removing the things to start over.

bspiegel33 commented 1 year ago

I unlinked my items, removed the things and started over. All the channels appeared. I relinked and good to go. Do you need additional debug files? I will continue to test. So far, looks great.

kpanchen commented 1 year ago

Glad it worked for you. I'm ok with logs for now. Please test the new channels, let me know if you see any abnormality. I'll continue working on "updates" and code clean-up.

A bit busy with work at the moment but want to drop it finally on the Market place.

K.

bspiegel33 commented 1 year ago

I did some testing. Setpoint changes work reliably and quick. Outdoor temp works well.
Zone Fan Mode is a problem. I could never get an OH change to be accepted by HVAC. Today, changes at the thermostat from auto to circ to ON do not reflect back in OH Fan Mode. I did these change to the downstairs zone and captured logs (attached). Changes at the thermostat for the downstairs zone fan from auto to on eventually reported back to OH Fan Status that the fan was on. It seems to be slow to alert OH.

Great progress on the binding. I hope my feedback helps. openhab.log

kpanchen commented 1 year ago

In the log you provided I don't see any attempts to set FAN mode, I see only some changes in temperature set and Home/Away.

When you change FAN mode you should see entry similar to this: 2023-04-15 02:52:15.987 [DEBUG] [andler.iComfortS30HeatingZoneHandler] - Executing command FAN_AUTO 2023-04-15 02:52:15.987 [DEBUG] [andler.iComfortS30HeatingZoneHandler] - Zone 0 already in Manual Mode, setting Fan operation mode And after some time you should see JSON response like this: {"messages":[{"MessageId":0,"SenderID":"LCC","TargetID":"mapp079372367620220702045015","MessageType":"PropertyChange","Data":{"zones":[{"publisher":{"publisherName":"lcc"},"status":{"fan":false,"allergenDefender":false,"humidity":43,"temperature":6.71250000000000000e+01,"damper":0,"heatCoast":false,"defrost":false,"humidityStatus":"good","period":{"systemMode":"off","fanMode":"auto","husp":40,"sp":73,"desp":55,"csp":72,"hsp":61,"hspC":16,"startTime":0,"humidityMode":"humidify","spC":2.25000000000000000e+01,"cspC":22},"humOperation":"off","scheduleExceptionIds":[],"balancePoint":"none","tempOperation":"off","ventilation":false,"demand":0,"aux":false,"coolCoast":false,"ssr":false,"temperatureStatus":"good","temperatureC":1.95000000000000000e+01},"id":0}]}}]}

Note that change is not immediate, it could be a few responses from HVAC before change is reflected but usually it is a few seconds, unfortunately this is their internal behaviour.

bspiegel33 commented 1 year ago

OH changes to Fan Mode tested and work fine. However, thermostat changes to Fan Mode do not update in OH ever.

Key learning: After a "heating" cycle completes, OH fan status reports ON when OH OpMode heating reports OFF. The fan runs until the HVAC heat dissipates. This is likely the way the HVAC reports things.

In circulation mode, I noticed the thermostat reports the fan running a few minutes before OH. Same with heating start, stop.

kpanchen commented 1 year ago

Thanks for reporting, turned out it is a huge bug in the underlying code, I will provide update ASAP.

Update: I've attached work in progress to fix this issue, please have a look. And big thanks!! org.openhab.binding.icomforts30-3.4.3-SNAPSHOT.jar.txt

bspiegel33 commented 1 year ago

It's been a while so I thought I'd check in on this issue. The 3.4.3snapshot file is a txt file. Was that the intention? I have not done anything with this file. If it merely needs the extension changed to use as a jar file, I can test it for you.

bspiegel33 commented 1 year ago

I finally found time to work on this and loaded the .jar.txt as .jat into openhab. Testing showed that the changes to temp settings now flow correctly from OH->Comfort and iComfort->OH. However, changes to AWAY only work from OH->Comfort. Changes to AWAY on Comfort do not update OH. I've attached the log.

Transaction timing: 7:28 iComfort away cancel - failed 7:33 iComfort away cancel - failed 7:35 - 7:38 temp changes to upstairs zone on iComfort and OH - all worked

openhab.log

kpanchen commented 1 year ago

Thank you!

Unfortunately I was busy with some other endeavours, didn't have time to work on it, I'll go back to dev table now.

Have you updated to version 4 of OH? My dev is still 3 but jar should work in 4 as well, no going back from 4 to 3.

K.

bspiegel33 commented 1 year ago

Welcome back.

I've migrated to V4 and the binding is working.