kpavlov / jreactive-8583

Kotlin/Java Client & Server for ISO8583 & Netty
Apache License 2.0
317 stars 140 forks source link

Production ready Server integration #118

Open malopezp91 opened 3 years ago

malopezp91 commented 3 years ago

Hi @kpavlov!

I am starting a project that needs to parse messages that follow the ISO8583 format. In the README, there is an example of how to make a Server that parses incoming messages; that example is also enriched with this one: https://github.com/mll11/jreactive-8583-sample-app/blob/master/iso8583server/src/main/java/com/simplytapp/iso8583/iso8583server.java

As you mention in the README, this project is based in Netty, to support non blocking io. My question is: How can this project be integrated into a Spring/SpringWebflux project, in order to avoid initializing and starting the server manually in the main class, as the example shows? I have not been able to find an example in the web. Or this setup can be considered production ready, by setting different listener implementations and probably calling static methods inside the onMessage method that can call Kakfa or even save to a Database?

Thanks!

Vostan commented 2 years ago

Hi,

I personally wanted to contribute a lot to this project for a long time now and did not have time so far. In my understanding, you have a valid point, however, if you check source code that should be a lot of work to switch underhood running netty with the netty coming with webflux. Also, you will lose the great flexibility of adding and removing handlers.

But anyways, it is good point. Lets see where this ticket will get to.