search

kpavlov / jreactive-8583

Kotlin/Java Client & Server for ISO8583 & Netty
Apache License 2.0
320 stars 144 forks source link

ISO 8583 standard version question #99

Closed solnaranu closed 4 years ago

solnaranu commented 4 years ago

Is there a specific reason the code below uses message type indicator 0x1644 (specifically, the digit 1), thereby assuming the 1993 version of the ISO 8583 standard, as opposed to the 1987 or 2003 versions?

https://github.com/kpavlov/jreactive-8583/blob/c9b180735de5046016af9a22e504199f7ddd69a1/src/main/java/com/github/kpavlov/jreactive8583/netty/pipeline/ParseExceptionHandler.java#L39

kpavlov commented 4 years ago

There is no specific reason. Should it be changed to 0x2644 ?

solnaranu commented 4 years ago

Only if you want to target the 2003 standard version specifically, but I doubt that since it is not really widely accepted.

Personally, I'm interested in the 1987 standard version and your lib works fine, with the exception of this.

On more thing to consider is that the underlying j8583 lib considers only 128 fields, and that would be the 1987 standard version (1993 has 192 fields).

I guess the simple way would be to use 0x0644. The more involved way would make it configurable.

kpavlov commented 4 years ago

Versions can be now customized (#103)