search

kpcyrd / sn0int

Semi-automatic OSINT framework and package manager
https://sn0int.readthedocs.io/
GNU General Public License v3.0
1.92k stars 177 forks source link

Dependency geo-types fails to build with Rust 1.67.0 #238

Closed ZhongRuoyu closed 1 year ago

ZhongRuoyu commented 1 year ago

Hi! Homebrew contributor here. While testing rust 1.67.0 in https://github.com/Homebrew/homebrew-core/pull/121561, we encountered failure while building sn0int 0.24.3. The failure seems related to its dependency geo-types:

     Compiling geo-types v0.7.7
  error: expected `,`, found `.`
     --> /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.com-1ecc6299db9ec823/geo-types-0.7.7/src/geometry/geometry_collection.rs:111:25
      |
  111 | #[deprecated(since = 0.7.5, note = "Use `GeometryCollection::from(vec![geom])` instead.")]
      |                         ^ expected `,`

  error: could not compile `geo-types` due to previous error

The error was extracted from a run on ARM-based macOS running Monterey, but it shouldn't be platform-specific. It seems related to https://github.com/georust/geo/pull/932, and should be fixed by bumping the geo dependency to a newer version. From what I see from https://github.com/georust/geo/commit/dbe5b4f1264fcf855e9c56096306e1bae65804aa, the fix was released in geo 0.23.1, which ships geo-types 0.7.8.

Thanks!

ZhongRuoyu commented 1 year ago

Thanks @kpcyrd for making the new release!

kpcyrd commented 1 year ago

You're welcome, let me know if there's something else I need to do to fix the homebrew package!