kpcyrd / spotify-launcher

Client for spotify's apt repository in Rust for Arch Linux
Other
191 stars 15 forks source link

Update fails: "Failed to find data entry in .deb" #52

Closed NicoRumm closed 2 weeks ago

NicoRumm commented 3 weeks ago

The update to spotify-client_1.2.47.364.gf06e5cee_amd64.deb (link) fails, because there is no "data.tar.gz" in the .deb file.

Instead there is "data.tar.xz" and this isn't handled by the code.

XLThinOreos1 commented 3 weeks ago

I am having the same problem and I'm glad I am not the only one.

ih8d8 commented 3 weeks ago

I'm having the same issue.

jcul commented 3 weeks ago

Same issue here, as a workaround for now, you can skip the update.

spotify-launcher --skip-update

Launches fine for me on the old version.

jcul commented 3 weeks ago

I created a pull request to just decompress the xz. Seems to work OK on the latest upstream deb.

https://github.com/kpcyrd/spotify-launcher/pull/53

IgorRSGraziano commented 3 weeks ago

Im having the same issue

Salvaju29ro commented 3 weeks ago

When I try to open it it continues to download, I click on the icon again and it downloads again. Is it the same problem?

Serpentarius13 commented 3 weeks ago

When I try to open it it continues to download, I click on the icon again and it downloads again. Is it the same problem?

Yes, you can try using command in terminal or journalctl

prstephens commented 3 weeks ago

When I try to open it it continues to download, I click on the icon again and it downloads again. Is it the same problem?

yup same here.

balejin commented 3 weeks ago

Currently having the same issue, when running with -v. @jcul method worked

eduardhojbota commented 3 weeks ago

Can confirm.

  ~ spotify-launcher                                                                                                                               09:50:26
[2024-09-26T06:50:44Z INFO  spotify_launcher::config] Loading configuration file at "/etc/spotify-launcher.conf"
[2024-09-26T06:50:44Z INFO  spotify_launcher::apt] Downloading release file...
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Downloading signature...
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Verifying pgp signature...
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Signature verified successfully!
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Downloading package index...
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Verifying with sha256sum hash...
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Downloading deb file for "spotify-client_1.2.47.364.gf06e5cee_amd64.deb" version="spotify-client" ("1:1.2.47.364.gf06e5cee")
[2024-09-26T06:50:45Z INFO  spotify_launcher::apt] Retrying download...
[2024-09-26T06:50:46Z INFO  spotify_launcher::apt] Verifying with sha256sum hash...
Error: Failed to find data entry in .deb
Davilarek commented 3 weeks ago

I would suggest using "👍" if this issue affects you guys, instead of spamming "same issue", as doing that doesn't bring anything new to this conversation

robvanderlee commented 3 weeks ago

This is breaking my client on Linux right now. I'm specifically using the Snap version to make application links work. As on Linux there is no other way to join jams other than the desktop app and a while back I discovered this only works on Manjaro through the snap version oddly enough.

It seems like both spotify and spotify-launcher binaries are packed together but the repositories are not up to date with the latest. The client does a version check on their own repositories that are ahead of the official application channels.

I've tried manually downloading the client with:

# Print the url to the deb package
spotify-launcher --print-deb-url

# Downloaded the package
cd ~/Downloads; wget http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.47.364.gf06e5cee_amd64.deb

# Try to load the deb
spotify-launcher --deb=/home/rob/Downloads/spotify-client_1.2.47.364.gf06e5cee_amd64_2.deb
[2024-09-26T08:40:40Z INFO  spotify_launcher::config] Loading configuration file at "/etc/spotify-launcher.conf"
Error: Failed to find data entry in .deb

It seems the deb is corrupt so it won't let me install this new version. Without the new version the client will try to update itself or alternativly with --skip-update ignore my jam urls alltogether... In addition, I cannot verify my 'corrupted' deb because there are no sums to verify against.

kpcyrd commented 3 weeks ago

Somebody submitted a patch: https://github.com/kpcyrd/spotify-launcher/pull/53

ragusa87 commented 3 weeks ago

Regarding the patch, I wonder if it is better to kill the app (bail) if the update failed (as it is today) or just output a warning (on stderr) and launch the non-updated binary ?

kpcyrd commented 3 weeks ago

Probably, that would also help with the cases when the signing key gets rotated.