kpdemetriou / siphash-cffi

Tested, performant SipHash bindings for Python 3 with support for double-output-size, half-word and variable-round variants.
https://pypi.org/project/siphash-cffi/
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Allow proper key lengths #2

Closed altendky closed 4 years ago

altendky commented 5 years ago

Full should allow 8 and 16 byte keys while half should allow 4 or 8 byte keys

1

altendky commented 5 years ago

Since the hashes in the test didn't have to change I guess CFFI was just truncating the incoming bytes and disabling the asserts in the C code. Maybe? I'll try to look more in the morning.

altendky commented 5 years ago

@kpdemetriou, any concerns or curiosities that I could help clear up?