Cadabra doesn't respect BUILD_SHARED_LIBS

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.

https://cadabra.science/

GNU General Public License v3.0

216 stars 37 forks source link

Cadabra doesn't respect BUILD_SHARED_LIBS #119

Closed yurivict closed 5 years ago

yurivict commented 5 years ago

BUILD_SHARED_LIBS=ON should force the shared library, but it always builds lib/libcadabra_client.a.

kpeeters commented 5 years ago

From what I remember this is a consequence of Windows not playing ball and me lacking time to figure out why. It really doesn't matter; this library is only used for the cadabra software itself, and not meant for public consumption. I should probably not have it installed though, you're right about that.

yurivict commented 5 years ago

Yes, you don't need to install libraries if there are no headers, and they aren't plugins, and aren't used in the run-time.

kpeeters commented 5 years ago

I think I fixed this at some point, or at least it does not install libcadabra_client.a anymore for me. Can you please check?

yurivict commented 5 years ago

BUILD_SHARED_LIBS now doesn't see, to do anything because cadabra2 doesn't install libraries any more.