Placeholders in the license file

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.

https://cadabra.science/

GNU General Public License v3.0

228 stars 37 forks source link

Placeholders in the license file #121

Closed hbarthels closed 5 years ago

hbarthels commented 5 years ago

While looking at the license file for the JOSS review, I noticed that there are still some placeholders, for example here:

https://github.com/kpeeters/cadabra2/blob/27b4e95e39bf70e6069c45211113df1dcc3c224e/LICENSE#L634

This is just for your information, I don't consider this a problem for the submission.

kpeeters commented 5 years ago

Thanks, I have used this file for zillions of projects and never realised there is that placeholder ;-)

kpeeters commented 5 years ago

Actually, that placeholder sits below the 'END OF TERMS AND CONDITIONS', inside an instruction to people using my software as part of their software. In which case they should stick in their own program name and author name, not mine. So I'll close this if you don't mind.

hbarthels commented 5 years ago

Yes, you are right, sorry. Looks like I scrolled too fast ;)