kpeeters / cadabra2

A field-theory motivated approach to computer algebra.
https://cadabra.science/
GNU General Public License v3.0
228 stars 37 forks source link

make install fails on ICONPATH-related tasks when executed by non-root #123

Closed jose-d closed 5 years ago

jose-d commented 5 years ago

There is hardcoded ICONPATH there in CMakeLists.txt, and some related commands which needs root privs.

This breaks the install process when installing into PREFIX without root privileges, even when user has rights to write into PREFIX.

As I build cadabra2 using EasyBuild, for now I did workaround patch: https://github.com/jose-d/ceico-easyconfigs/blob/master/cadabra-2.2.4-foss-2018b_move_icondir.patch

But perhaps this deserves some systematical fix.

kpeeters commented 5 years ago

Commit b354300c95b5b9e41b2f6480f69c4f92c2c35a7b should fix this. You need to run update-cache otherwise icons will not show, so I have not used that part of your patch.