kpeeters / cadabra2

A field-theory motivated approach to computer algebra.
https://cadabra.science/
GNU General Public License v3.0
228 stars 37 forks source link

`unwrap` does not handle differential form correctly #169

Closed Doxdrum closed 5 years ago

Doxdrum commented 5 years ago

When using unwrap, the "status" of form is lost, e.g. in the image below see the introduction of a "1".

image

kpeeters commented 5 years ago

Ouch, I made unwrap look for DifferentialForm properties in the wedge product, but should of course have used DifferentialFormBase, which will also work for exterior derivatives. The 8-character fix is now on github.

Doxdrum commented 5 years ago

Hi @kpeeters, the problem persists. Look the new behaviuor,

image I'll try to understand how it works, and give you feedback. Thank you!

kpeeters commented 5 years ago

You have declared A both as a form of degree=0 and one of degree=1. That's not going to work.

Doxdrum commented 5 years ago

Utchhh... my fault! thank you for the answer!