search

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.
https://cadabra.science/
GNU General Public License v3.0
215 stars 37 forks source link

New combine() logic #181

Closed cbehan closed 4 years ago

cbehan commented 4 years ago

Changing parent relations and factor ordering in the initial expression should not affect the output of combine().

kpeeters commented 4 years ago

I have fixed test08 and merged into master. One of the things that is still not quite right is test06:

{a,b}::Indices(vector);
ex:=(A)_{a b} (B)_{b a};
combine(_)

which produces B A rather than A B. That's only correct if the components of A and B commute.