search

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.
https://cadabra.science/
GNU General Public License v3.0
215 stars 37 forks source link

Make a stable release artifact #195

Closed isuruf closed 4 years ago

isuruf commented 4 years ago

Github's autogenerated archives change their auto-generated contents depending on the git version that they use internally and therefore the sha256 of the archive change. To fix this, many projects download the autogenerated archive and re-upload as a release artifact which is stable.

kpeeters commented 4 years ago

In which situation is this a problem? If you are fetching a tarball for building another package, then it is probably a better idea anyway to fetch a release tarball, and as far as I can see, those remain unchanged. Are you saying that that is not true?

isuruf commented 4 years ago

those remain unchanged. Are you saying that that is not true?

Yes. That is untrue. See https://github.com/spack/spack/issues/5411

kpeeters commented 4 years ago

If I read https://github.com/easybuilders/easybuild-easyconfigs/issues/5151 correctly, this does not seem to be an issue with release tarballs. Indeed, release 2.2.8 made on December 10th still has the same sha256. I'd rather not set up a lot of additional infrastructure if it isn't really a problem (I have plenty to do when generating new releases already, to the extent that it typically does not happen at all in any sort of coordinated manner).

Not to shoot your suggestion down; on the contrary, it's much appreciated that you are on top of this, just trying to keep my own sanity.

isuruf commented 4 years ago

release tarballs are different than what you have right now. For example if you see https://github.com/symengine/symengine/releases/tag/v0.6.0 you'll notice three links. The first one is a release artifact and the 2nd and 3rd are auto-generated archives. In https://github.com/kpeeters/cadabra2/releases/tag/2.2.8 I don't see any release tarballs, just auto-generated archives.

This is just an FYI though. Not a must.