search

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.
https://cadabra.science/
GNU General Public License v3.0
215 stars 37 forks source link

Build Failure: cadabra-cli missmatched cython _Py_Identifier attributes (cmake?) #256

Closed talleyhoe closed 1 year ago

talleyhoe commented 1 year ago

There's an error handing function in core/cadabra2-cli.cc (void Shell::handle_error(py::error_already_set& err)) with reference to cpython/objects.h 's _Py_Identifier.

It seems like there's a check for correct python-version, under PY_VERSION_HEX but in Config.hh PYTHON_VERSION_MAJOR (and MINOR) are being defined. I think this might be a cmake issue??

I was able to build and pass all tests after editing this section.

talleyhoe commented 1 year ago

It looks like the check against the PY_VERSION_HEX isn't included in the 2.3.8 release's tarball?

kpeeters commented 1 year ago

Why are you using 2.3.8? Can you please clone the current master (which is at 2.3.9.3) and let me know if the problem persists?

talleyhoe commented 1 year ago

Oops, I was just pulling the latest version under 'releases'. Works great on 2.3.9.3! Thanks