docker: fix PYTHONPATH with entrypoint

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.

https://cadabra.science/

GNU General Public License v3.0

230 stars 37 forks source link

docker: fix PYTHONPATH with entrypoint #308

Closed fjebaker closed 3 months ago

fjebaker commented 3 months ago

Added an entrypoint file so that the PYTHONPATH can be set within the running container's environment.

fjebaker commented 3 months ago

Just a few observations and notes:

Syntax highlighting is broken, and the fix I have in my Dockerfile doesn't seem to work on this version of Jupyter. The way I had debugged this previously also doesn't work, so will have to address that in the future.
The Docker container should ideally not run as root, and there should be a cadabra user created for the running container.
The image comes in at about 1GB, which is fine, but I think we can likely get that smaller.

kpeeters commented 3 months ago

You can now get this from my dockerhub repo at https://hub.docker.com/r/kpeeters/cadabra2-jupyter. For some reason this still complains about not being able to find cadabra2_jupyter as soon as you create a cadabra notebook. If you spot the issue, let me know.

(This builds automatically on github and pushes to dockerhub on every github commit, so it will at least always be up-to-date; now we just have to make it work ;-) ).

kpeeters commented 3 months ago

It's 357.43 MB compressed by the way. Can probably remove things from the base layer to make it smaller still.

kpeeters commented 3 months ago

This seems to work now for me on both amd64 and arm64.