ICON_PREFIX should always be ${CMAKE_INSTALL_PREFIX}, not only for APPLE

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.

https://cadabra.science/

GNU General Public License v3.0

223 stars 37 forks source link

ICON_PREFIX should always be ${CMAKE_INSTALL_PREFIX}, not only for APPLE #75

Closed yurivict closed 6 years ago

yurivict commented 6 years ago

This is wrong: https://github.com/kpeeters/cadabra2/blob/master/frontend/gtkmm/CMakeLists.txt#L129

kpeeters commented 6 years ago

We've been here before, https://github.com/kpeeters/cadabra2/issues/34. If you have any new insight into this, let me know. Icons installed in any place other than below /usr simply do not get picked up by most Linux distros. If you have CMAKE_INSTALL_PREFIX=/usr/local, your suggestion would mean no icon. I know my solution is wrong too, but at least it gets the job done.

Am happy to make ICON_PREFIX be CMAKE_INSTALL_PREFIX on FreeBSD if that makes your life easier.

yurivict commented 6 years ago

Sorry, I forgot. I will write the insight there.