search

kpeeters / cadabra2

A field-theory motivated approach to computer algebra.
https://cadabra.science/
GNU General Public License v3.0
223 stars 37 forks source link

USE_PYTHON_3=OFF doesn't work #76

Closed yurivict closed 2 weeks ago

yurivict commented 6 years ago

It still linked to python2. I have both installed on FreeBSD. There can be many python versions installed. You should have a cmake variable which accepts the python executable, and then you should read everything else from it.

kpeeters commented 6 years ago

Giving the status of python2, I am not going to spend more energy into building against that. Should probably get rid of USE_PYTHON_3 altogether.

yurivict commented 6 years ago

There still can be a problem in selection of python-3.5 vs. python-3.6 for example.

kpeeters commented 6 years ago

It's something worth doing at some point, but requires careful testing. At the moment I am happy that the lot builds on all the various platforms; I would like to avoid introducing changes which are likely to break the build on one of them.

yurivict commented 6 years ago

I am not saying that this is urgent, it's rather something to keep in mind. Once you have a patch I will be happy to test it. FreeBSD might be the best platform to test it because one can easily install all possible python versions at the same time. Currently, this is a source of potential incorrectness in the FreeBSD port.

kpeeters commented 2 weeks ago

Python 2.x is no longer supported (hasn't been for some time) so I am closing this.