search

kpeiruza / docker-hashtopolis-server

Hastopolis Server Docker image
GNU General Public License v3.0
18 stars 16 forks source link

Fixes and additions #7

Closed Gitoffomalawn closed 1 year ago

Gitoffomalawn commented 1 year ago
Gitoffomalawn commented 1 year ago

Please, keep the volumes as named volumes instead of local paths. IMO it's a bit safer and cleaner.

You're right. I just copied and pasted my docker-compose.yaml after getting everything to work. For experiments I like to keep everything contained to one folder I can then easily get rid of. Forgot to change those back.

I like the change from mysql to mariadb. Have you tried an even newer version of mariadb?

I have not . I was trying for hours to solve the MySQL problems using the mysql:5.7 image, when I finally gave up and switched to a MariaDB version I thought would work (which it did, on the first try). After that I didn't really feel like experimenting with the images any further.

It should work though, depending on the default authentication mechanism employed by MariaDB. If they didn't go the route that MySQL went in with 8.0+ with the SHA2 hash logins but stuck with password-based authentication in more recent MariaDB versions, I don't see why it shouldn't work. I knew that martiadb:5.5 uses this, which is why I was confident it would present a minimal shift from mysql:5.7.

ETA: Just did a quick test with mariadb:latest. It works just fine, and, arguably, much faster than mariadb:5.5. That said, it'll probably be best to choose a fixed image for the sake of stability.

Are you sure that echo's for APACHE CONFIG work?

As far as I can recall, that 000-default.conf ends with so this directive would be outside of the VirtualHost.

Besiders, that's cleaner with just 1 echo '' or a cat <EOF.

In any case, why do you need AllowOverride All if you aren't creating a .htaccess or similar?

You can achieve the same with a sed -i, isn't it?

The echos work. Though I'll admit I'm unsure whether they are strictly necessary. In my quest to add missing environment parameters to the entrypoint.sh I just followed the steps in the Hashtopolis setup video posted by its maintainer, which specifically mentions these additions in this place. By the time I got to that point, and not being 100% with how the docker image functions, I was in a "if it doesn't help, it surely can't hurt" state of mind. If they aren't necessary, I'm more than happy to remove them.

The rest looks great :-)

Thanks. and no problem, man. These are the kind of projects that are super handy, and very under-supported. Being able to roll out Hashtopolis in just a few minutes with little to no manual interventions (you still need to change file permissions on the volumes after the container goes up) is super handy.

Gitoffomalawn commented 1 year ago

Thanks!

No problem, man. I'm also going to look into making the README a bit more easy to follow, since the instructions aren't very clear, and some steps and information are missing. But I'll do a separate PR for that. Keeps things manageable.

kpeiruza commented 1 year ago

Please, keep the volumes as named volumes instead of local paths. IMO it's a bit safer and cleaner.

You're right. I just copied and pasted my docker-compose.yaml after getting everything to work. For experiments I like to keep everything contained to one folder I can then easily get rid of. Forgot to change those back.

I like the change from mysql to mariadb. Have you tried an even newer version of mariadb?

I have not . I was trying for hours to solve the MySQL problems using the mysql:5.7 image, when I finally gave up and switched to a MariaDB version I thought would work (which it did, on the first try). After that I didn't really feel like experimenting with the images any further.

It should work though, depending on the default authentication mechanism employed by MariaDB. If they didn't go the route that MySQL went in with 8.0+ with the SHA2 hash logins but stuck with password-based authentication in more recent MariaDB versions, I don't see why it shouldn't work. I knew that martiadb:5.5 uses this, which is why I was confident it would present a minimal shift from mysql:5.7.

ETA: Just did a quick test with mariadb:latest. It works just fine, and, arguably, much faster than mariadb:5.5. That said, it'll probably be best to choose a fixed image for the sake of stability.

Are you sure that echo's for APACHE CONFIG work? As far as I can recall, that 000-default.conf ends with so this directive would be outside of the VirtualHost. Besiders, that's cleaner with just 1 echo '' or a cat <EOF. In any case, why do you need AllowOverride All if you aren't creating a .htaccess or similar? You can achieve the same with a sed -i, isn't it?

The echos work. Though I'll admit I'm unsure whether they are strictly necessary. In my quest to add missing environment parameters to the entrypoint.sh I just followed the steps in the Hashtopolis setup video posted by its maintainer, which specifically mentions these additions in this place. By the time I got to that point, and not being 100% with how the docker image functions, I was in a "if it doesn't help, it surely can't hurt" state of mind. If they aren't necessary, I'm more than happy to remove them.

The rest looks great :-)

Thanks. and no problem, man. These are the kind of projects that are super handy, and very under-supported. Being able to roll out Hashtopolis in just a few minutes with little to no manual interventions (you still need to change file permissions on the volumes after the container goes up) is super handy.

It's lovely to see people using this docker and finding it useful :-)

Gitoffomalawn commented 1 year ago

It's lovely to see people using this docker and finding it useful :-)

For sure. Let me know if there's anything else I need to do for this PR.

kpeiruza commented 1 year ago

For this PR, just that.

Feel free to make a proper README.md, I'm not a native English speaker.

Missatge de Gitoffomalawn @.***> del dia dv., 5 de maig 2023 a les 12:00:

It's lovely to see people using this docker and finding it useful :-)

For sure. Let me know if there's anything else I need to do for this PR.

— Reply to this email directly, view it on GitHub https://github.com/kpeiruza/docker-hashtopolis-server/pull/7#issuecomment-1536021432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADI5TYRR4NAOK7RTZZUSHSLXETFVRANCNFSM6AAAAAAXWLKKKU . You are receiving this because you commented.Message ID: @.***>

Gitoffomalawn commented 1 year ago

For this PR, just that.

By that, did you mean the volume names? Or did you want me to remove/modify the 000-default.conf echos too?

Feel free to make a proper README.md, I'm not a native English speaker.

No problem. I'll see if I can sink some time into it.

kpeiruza commented 1 year ago

New Docker image pushed, Hashtopolis has been updated as well, please try it out, I'm on a bit busy day....

Thanks!