Actions: Docker image tags

kpetremann / mqtt-exporter

Simple generic MQTT Prometheus exporter for IoT working out of the box

https://hub.docker.com/r/kpetrem/mqtt-exporter

MIT License

108 stars 30 forks source link

Actions: Docker image tags #34

Closed kpetremann closed 1 year ago

kpetremann commented 2 years ago

Issue to track the request from https://github.com/kpetremann/mqtt-exporter/issues/32#issuecomment-1228749043

Improve docker image release workflow by pushing tags

onedr0p commented 1 year ago

Hi @kpetremann it would also be great if you could push your image to the Github Container registry.

I have opened a PR here https://github.com/kpetremann/mqtt-exporter/pull/39

kpetremann commented 1 year ago

Hi @onedr0p, sure why not. I'll have a look next week.

Out of curiosity, why would you like to have it in Github Container Registry as well? the usual docker registry is working fine.

onedr0p commented 1 year ago

Because dockerhub has aggressive rate limits, 100 pulls per 6 hours for unauthenticated and 200 pulls per 6 hours for authenticated pulls. Dockerhub also has aggressive retention limits too.

kpetremann commented 1 year ago

Docker images are now pushed with tags:

"master" tag when only pushing or merging PR to the master
"1.2.3", "1.2", "1" and "latest" tags when pushing a tagged version

onedr0p commented 1 year ago

This is awesome, thanks!