Closed Matthew-Beckett closed 5 months ago
Hello @Matthew-Beckett,
Nice, thanks for this contribution! Could you please just fix the error reported by the CI? I'll merge it once good.
@kpetremann needs Action running
@kpetremann can you offer some insight into how they imports are failing the tests?
@Matthew-Beckett sure, you just need to run isort .
to fix the issue.
Result on my side:
#!/usr/bin/env python3
"""MQTT exporter."""
import fnmatch
import json
import logging
import re
import signal
import ssl
import sys
import paho.mqtt.client as mqtt
from prometheus_client import Counter, Gauge, start_http_server
from mqtt_exporter import settings
logging.basicConfig(level=settings.LOG_LEVEL)
LOG = logging.getLogger("mqtt-exporter")
...
If it can help, this is documented in https://github.com/kpetremann/mqtt-exporter/blob/master/CONTRIBUTING.md
hello @Matthew-Beckett, was my last message helpful?
Yes, sorry, just been very busy. Will resolve this ASAP.
Hi @Matthew-Beckett,
I am closing this PR as I created a replica with needed rebase and fixes - including your commit with you as author :)
see #75
Fixes/Implement: TLS support for MQTT endoints
Description:
This PR will allow you to connect to TLS secured MQTT endpoints. It also allows you to disable verification of the server's certificate if it is not signed by an trusted CA.
Before the commit:
After the commit: