search

kpetremann / mqtt-exporter

Simple generic MQTT Prometheus exporter for IoT working out of the box
https://hub.docker.com/r/kpetrem/mqtt-exporter
MIT License
103 stars 29 forks source link

Add basic pyproject properties & `PROMETHEUS_ADDRESS` setting #73

Closed christoph-heiss closed 6 months ago

christoph-heiss commented 6 months ago

Fixes/Implement: -

Description:

First, add some basic properties in pyproject.toml as laid out in the Python Packaging guide. This helps distribution and such to easier package mqtt-exporter. Hopefully these are okay as-is.

Second, add a new, pretty straight-forward PROMETHEUS_ADDRESS setting, to be able to specify the address mqtt-exporter should listen on. Users might want their mqtt-exporter to e.g. just listen on localhost, thereby also reducing the risk of accidentally exposing it to the network.

Cheers, Christoph

kpetremann commented 6 months ago

Hi @christoph-heiss,

Thanks for the contrib! Could you please rebase your PR. I've done a change to make the CI happy :)