kpfromer / nestjs-typegoose

Typegoose with NestJS
https://kpfromer.github.io/nestjs-typegoose/
MIT License
291 stars 71 forks source link

Support/ update to NestJS v8 and others #433

Open smolinari opened 3 years ago

smolinari commented 3 years ago

@kpfromer - Can you keep up the maintenance of this package? Would be awesome. Nest is on version 8 and Typegoose is going to be hopefully also going to version 8 soon.

At any rate, this package is falling behind quickly. 😬

Scott

smolinari commented 3 years ago

I've create a PR to update the package. Not sure if it is right or good. Just trying to help.

Scott

smolinari commented 3 years ago

Since it seems this project has been abandoned or rather I don't want to wait weeks to get updates/ fixes I've decided to fork it to my project and take care of it. I'm not sure what the proper procedure is for doing this. Hope I'm not stepping on anyone's toes, as that is not my intention. I realize people do these projects voluntarily (and hugely appreciate the efforts) and thus, sometimes no longer have the time or even motivation to continue to support them. I do and want to.

If I'm doing anything wrong or out of place, please let me know.

Scott

kpfromer commented 3 years ago

Hey Scott, sorry to be so distant with the responses. Things have been quite busy with work and school. I will try to review your code shortly, and thanks for the PR.

I'm not sure what the proper procedure is for doing this. Hope I'm not stepping on anyone's toes, as that is not my intention.

Yeah, my support for this project has been lacking since I am quite busy, so definitely feel free to fork the project!

smolinari commented 3 years ago

@kpfromer - Hey. Nice to see you. I'd be very interested in your feedback with my PR. To be honest, I'm not the greatest programmer (it's a hobby) and I'm sure there are a ton of mistakes. Also, it seems my reasoning for needing the updating was unfounded and to be honest, I can't remember the reasoning either. I believe it was a mismatch in peer dependencies I was running into, now that Nest is at v8.

At any rate. Just trying to help, as I am using NestJS and Typegoose (and recommend it where I can), and this package is key to that "marriage". 😁

Scott

shahriar-shojib commented 3 years ago

Typegoose 8 was released today

smolinari commented 3 years ago

Actually, 8.1 has also been released. 😁

Scott

DanielEberl commented 3 years ago

Hey, what is going on with the 58 open pull requests?

I can definetly help maintaining this package if you need help. I can take my time since we rely heavily on this package.

Feel free to DM me or add me as a collaborator.

kpfromer commented 3 years ago

Hey, what is going on with the 58 open pull requests?

I can definitely help maintaining this package if you need help. I can take my time since we rely heavily on this package.

Feel free to DM me or add me as a collaborator.

Yeah @DanielEberl, I could definitely use the help. College is starting back up, and classes are getting quite tough. Thus I won't have that much time to devote to open-source projects. As for the 58 prs, I think dependabot is not auto merging.

kpfromer commented 3 years ago

I am also trying to get Github actions up and working with semantic release, but I have run into a few problems with branch protections. Hopefully when that is working auto merging should be fixed.

MarcBollmann commented 2 years ago

Any updates on this?

smolinari commented 2 years ago

Yeah, even my PR is outdated now. Typegoose is at version 9, but it seems everything is still working. Still, this gem of a package should be updated to keep up. 😀

Scott

MarcBollmann commented 2 years ago

@smolinari I saw your fork seems to be more updated than this one

smolinari commented 2 years ago

@MarcBollmann - It is. I'd need to do some more updating though. Maybe I'll do it tomorrow.

Scott

AlexBollmann commented 2 years ago

any updates on this?

smolinari commented 2 years ago

I personally have forked it and updated myself. I haven't pushed the changes here, as it seems this project is dead. If anything, later, I'll be posting it as a library package to my project. That will be a while though.

Scott

kamalkech commented 2 years ago

@smolinari i guess we need to remove this package from our projects, cuz any reactivity or support for this package!!

AlexBollmann commented 2 years ago

@kamalkech if you have any knowledge how to proceed without this package, please share 😁 I also thought about forking it, but I'm really not that deep into this topic rigt now..