search

kpfromer / nestjs-typegoose

Typegoose with NestJS
https://kpfromer.github.io/nestjs-typegoose/
MIT License
291 stars 73 forks source link

Updates to NestJS v8 Fixes #433 #434

Open smolinari opened 3 years ago

smolinari commented 3 years ago

I hope this is ok. I'm not the most experienced at this. Any critique (and I'm sure there will be some) is welcome. I'm learning.

Fixes #433

Scott

kpfromer commented 3 years ago

Hey, sorry for the late reply. I will try to get this reviewed over the weekend.

kpfromer commented 3 years ago

@smolinari Do you need a re-review?

smolinari commented 3 years ago

@smolinari Do you need a re-review?

I will. Typegoose v8 just went final. I need to update that dep.

Edit. Ok. Updated.

Scott

smolinari commented 3 years ago

Hey Kyle,

I missed your "any updates" and to be honest, I'm not sure anymore where this stands. Aaaannnd, Mongoose has moved to version 6 and with it there are breaking changes.

What should we do? Or what can I do? I'm going to work on fixing the current issue with mongoose 6. But, what else should I do? And should I do it through another PR, or continue with this one? I'd imagine, this package would also need to be moved up to 8.0?

Scott

smolinari commented 3 years ago

Forgot to ping you above. @kpfromer

Scott

duongdev commented 2 years ago

Hey @smolinari @kpfromer, any updates on this PR?

smolinari commented 2 years ago

@duongdev - I've just created my own fork. I haven't updated it in a few months though either. So, also not up-to-date. But, it should be working. Let me know if you have any issues on my fork in Github. https://www.npmjs.com/package/@m8a/nestjs-typegoose

Scott

GwendalBroudin-Emoko commented 2 years ago

Hi @smolinari your repo show a 404 on Github. Is it private ?

smolinari commented 2 years ago

@GwendalBroudin-Emoko - No. It's just somewhere else. I've updated the package and also the repo link (sort of).

Scott