search

kphanipavan / modal_progress_hud_nsn

Modal animated loading overlay package for long running tasks.
https://pub.dev/packages/modal_progress_hud_nsn
MIT License
6 stars 10 forks source link

latest flutter versions require kotlin 1.5.31 #3

Closed philippkeller closed 2 years ago

philippkeller commented 2 years ago

I tried to use your Flutter module with a recent flutter version (version 3.0.1, android api 32) and got compiler error. Being a flutter beginner myself (currently doing Angela Yus Flutter course where modal_progress_hud is suggested), I pointed it down to [this page(https://docs.flutter.dev/release/breaking-changes/kotlin-version) where flutter seems to require kotlin 1.5.31 upwards.

As your project had a smaller version number configured it was failing. I removed the kotlin version number and now it's compiling (I assume it falls back to the Kotlin version of the IDE?). I'm not sure this is the proper fix but at least it did it for me.

kphanipavan commented 2 years ago

Not sure if this is a recommended way to do it, but I prefer to keep the variable as it is and update the version everytime I update the package...

Updated the package to 0.2.0 with additional platform support.

Change version to latest kotlin version, will merge it when the conflits are resolved.

philippkeller commented 2 years ago

I agree. I just figured out that when the version number is missing in your module then I'm forced to put it into my project - which I usually don't need. Do you know what happens when your module has a higher version number configured than my IDE?

kphanipavan commented 2 years ago

Do you know what happens when your module has a higher version number configured than my IDE?

You mean Android Studio, not sure. The version specified in the flutter package might take the precedence. It depends on how the flutter extension is built to handle this.

I use basic IDEA which has no such builtin things...

philippkeller commented 2 years ago

Yes, I'm using Android Studio, where you have a "built in" kotlin version. But I guess the build process can also use a different kotlin version. I see that you just committed something with some other changes, nice to see this module to be revived 🎉

kphanipavan commented 2 years ago

Closing this PR... Comment if necessary.