search

kpi-web-guild / django-girls-blog-OlenaEfymenko

django-girls-blog-OlenaEfymenko created by GitHub Classroom
MIT License
1 stars 0 forks source link

Add config file for pylint #28

Closed OlenaYefymenko closed 11 months ago

OlenaYefymenko commented 11 months ago

The pylintrc configuration allows adjustments to various pylint checker options. In the future, config will be complemented by other parameters during the writing project.

webknjaz commented 11 months ago

That title seems too long and too vague. Also, a description wouldn't hurt.

OlenaYefymenko commented 11 months ago

That title seems too long and too vague. Also, a description wouldn't hurt.

Unfortunately, I can't remember what exactly the error I had in the first PR with .pylintrc. For a long time, I coudn't resolve this. Then I noticed this example with local settings, also without any version. I just read about the pros and cons of the implementation of these variants and chose the optimal variant. Without experience, I can't provide any own argumentation, only based information on the Internet

webknjaz commented 11 months ago

Then, postpone the PR until you face the problem again.

OlenaYefymenko commented 11 months ago

Then, postpone the PR until you face the problem again.

@webknjaz I am going to push PR Initialize Django project #22, but when I run python -m pre_commit run --all-files have the message The config file .pylintrc doesn't exist!. I have doubts what I should do. Better to add this config file or just merge this PR before #22.

OlenaYefymenko commented 11 months ago

I'm sorry, I forgot about pylint --generate-rcfile | tee .pylintrc. I will repush

OlenaYefymenko commented 11 months ago

I tried to execute Add suggestion to batch and have doubts about whether it's working. I also noticed this: https://github.com/refined-github/refined-github/issues/2122. Perhaps I should make changes locally. I have hesitation, that commit suggestion isn't a good idea because it results in numerous commits that would be better if squashed.

webknjaz commented 11 months ago

Batching commits only works in the Files tab IIRC. You can pull the changes and edit the commits afterwards.