search

kpi-web-guild / django-girls-blog-OlenaEfymenko

django-girls-blog-OlenaEfymenko created by GitHub Classroom
MIT License
1 stars 0 forks source link

Integrate post list view for the Blog application #36

Closed OlenaYefymenko closed 5 months ago

OlenaYefymenko commented 7 months ago

This PR provides a view function for displaying a list of posts and URL configuration. It also includes templates and static files to support rendering the blog posts.

Ref #18

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.61%. Comparing base (a22b3cb) to head (44271c7). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== + Coverage 84.00% 89.61% +5.61% ========================================== Files 5 6 +1 Lines 50 77 +27 Branches 2 6 +4 ========================================== + Hits 42 69 +27 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OlenaYefymenko commented 7 months ago

I w'd like to clarify about test some details, maybe I should use @patch? Also, I assume that freezegun could be a good option for testing different dates.

And I have hesitation about the length of lines in code, perhaps I can change this? Or is it better to keep it at 79 characters?

OlenaYefymenko commented 5 months ago

Thank you! It looks like we can merge PR. But, I don't understand how codecov works as if it's not stable.

webknjaz commented 5 months ago

Codecov is known to be flaky and has processing delays sometimes, which is why many people implement https://hynek.me/articles/ditch-codecov-python/.