search

kpi-web-guild / django-girls-blog-OlenaEfymenko

django-girls-blog-OlenaEfymenko created by GitHub Classroom
MIT License
1 stars 0 forks source link

Add isort hook fot the pre-commit tool #37

Closed OlenaYefymenko closed 7 months ago

OlenaYefymenko commented 8 months ago

This change provides the sorting of imports alphabetically and groups them by section and type.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2a0f622) 84.00% compared to head (a22b3cb) 84.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ======================================= Coverage 84.00% 84.00% ======================================= Files 5 5 Lines 50 50 Branches 2 2 ======================================= Hits 42 42 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

webknjaz commented 7 months ago

Keep formatters before the linters so that you won't get double errors. Let linters check files after the formatting changes happen.

OlenaYefymenko commented 7 months ago

Keep formatters before the linters so that you won't get double errors. Let linters check files after the formatting changes happen.

Yes, it makes sense. Thank you.