Pre-commit integration - Githubissues

kpi-web-guild / django-girls-blog-RootenberG

django-girls-blog-RootenberG created by GitHub Classroom

MIT License

0 stars 0 forks source link

Pre-commit integration #18

Closed RootenberG closed 5 years ago

RootenberG commented 5 years ago

Closes #14

webknjaz commented 5 years ago

@RootenberG You need to put whitespace between a closing keyword and an issue number.

igorkruglyak commented 5 years ago

Closes #14

You can to write more comments. For example

Closes #14

Ref: https://pre-commit.com

This commit includes the initial configuration for the following pre-commit hooks:

no-commit-to-branch
add-trailing-comma
remove-tabs
trailing-whitespace
check-merge-conflict
double-quote-string-fixer
requirements-txt-fixer
check-yaml
check-docstring-first
end-of-file-fixer
name-tests-test
check-ast
debug-statements
flake8
pydocstyle
pylint using "local" mode
mypy

webknjaz commented 5 years ago

Plz clean up your commits

RootenberG commented 5 years ago

Plz clean up your commits

What do you mean?

webknjaz commented 5 years ago

You have a fixup commit which by itself is only useful combined with another commit. Squash them into one atomic thing.

RootenberG commented 5 years ago

You have a fixup commit which by itself is only useful combined with another commit. Squash them into one atomic thing.

Done.

RootenberG commented 5 years ago

I,m not authorized to merge this pull request.(

webknjaz commented 5 years ago

@RootenberG you can merge it now